Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.18] Added italian localisation #1011

Open
wants to merge 10 commits into
base: 1.18
Choose a base branch
from
Open

[1.18] Added italian localisation #1011

wants to merge 10 commits into from

Conversation

BlackShadow77
Copy link

@BlackShadow77 BlackShadow77 commented Apr 2, 2022 •
edited
Loading

Added Italian Localisation.

@BlackShadow77 BlackShadow77 changed the title Added italian localization Added italian localization (1.18) Apr 2, 2022
@BlackShadow77 BlackShadow77 changed the title Added italian localization (1.18) Added italian localisation (1.18) Apr 2, 2022
maicol07
maicol07 suggested changes Apr 2, 2022
View reviewed changes
Copy link

@maicol07 maicol07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Drawer" shouldn't be left as is, but it should be translated. Also, the source was plural, although the item is one (in its 1x1 version).
I'm not sure about the mod name: should we leave it with the original name or also translate it in italian?

src/main/resources/assets/storagedrawers/lang/it_it.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/it_it.json Outdated Show resolved Hide resolved
src/main/resources/assets/storagedrawers/lang/it_it.json Outdated
"tooltip.storagedrawers.waila.nolimit": "Limite di Stacks: ∞",
"tooltip.storagedrawers.waila.limit": "Limite di Stacks: %s (x%s)",
"tooltip.storagedrawers.waila.locked": "Bloccato",
"tooltip.storagedrawers.waila.void": "Vacuo",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't "Vuoto" better?

Copy link
Author

@BlackShadow77 BlackShadow77 Apr 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is!
But i think we should investigate more in the context.

Copy link
Author

@BlackShadow77 BlackShadow77 Apr 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find a word that let understand items will be destroyed when exceeding and "vuoto" don't fit well with this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaquadro can you give us some context for this?

@BlackShadow77
Copy link
Author

I think "Drawer" shouldn't be left as is, but it should be translated. Also, the source was plural, although the item is one (in its 1x1 version). I'm not sure about the mod name: should we leave it with the original name or also translate it in italian?

You're right, we should translate "Drawer" but "Cassetto" sounds not appropriate in this context, maybe should we think another word?
About mod name: I always think we should leave it with original name, for recognizability reason also with others mods in modpacks.

@BlackShadow77
Update it_it.json
5b98f01
@BlackShadow77
Update it_it.lang
d5c2994 
Changed "Controllore" to "Gestore"
BlackShadow77
BlackShadow77 commented Apr 2, 2022
View reviewed changes
Copy link
Author

@BlackShadow77 BlackShadow77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update files to match better italian language

@BlackShadow77
Create it_ch.json
74df98d 
added italian localisation for swiss italian
@BlackShadow77
Create it_ch.lang
b0140df 
added localisation for swiss italian
@BlackShadow77
Copy link
Author

I also added files for Swiss Italian translation

@BlackShadow77
Update it_ch.json
1ee4aa4 
updated with a better traslation for drawer.
@BlackShadow77
Update it_it.json
8b0fb45 
updated with a better traslation for drawer.
@BlackShadow77
Update it_it.lang
3baa2c7 
updated with a better traslation for drawer.
@BlackShadow77
Update it_ch.lang
d0dce29 
updated with a better traslation for drawer.
@BlackShadow77
Copy link
Author

@maicol07 i updated the traslation with a new traslation for "drawer"; i think "cassettiera" wear good on it. Let me know your opinion!

@BlackShadow77 BlackShadow77 changed the title Added italian localisation (1.18) [1.18] Added italian localisation Apr 15, 2022
@BlackShadow77 BlackShadow77 mentioned this pull request Sep 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicol07 maicol07 maicol07 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BlackShadow77 @maicol07