build/ci: Add coverage support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of hair-tearing, and then eventually finding the right keyword to search for. Thanks again phst: https://github.com/phst/rules_elisp/blob/f9664cf0e5c86653bffd1a02b7c0cccb4d27e979/elisp/defs.bzl#L214 Also thanks https://github.com/c-mita/bazel_issues/blob/d217e2b7e7dc71088b7e02ddaa25a8f6b0f7d880/coverage_common/README.md?plain=1#L47 The magic is documented with the comment, copied from phst. We need to provide the hidden coverage collection binaries and test environment pointing to them. We also must return the instrumented files provider listing the attribbutes that contain its sources. Now a bazel coverage ... generaets a report!
jaqx0r
force-pushed
the
bazel-cover
branch
7 times, most recently
from
c1fa412
to
6e73d25
Compare
Turn the wrapper generator into a new action using `expand_template`.
Github Actions have 1.6.2 which seems to have quite different behaviour than 1.6.3.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=======================================
Coverage ? 46.43%
=======================================
Files ? 22
Lines ? 3228
Branches ? 482
=======================================
Hits ? 1499
Misses ? 1729
Partials ? 0 ☔ View full report in Codecov by Sentry. |
We need `expect` for dejagnu, but the latter is now being fetched by bazel directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.