Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version constraint for pytest-mypy #16

Merged
merged 1 commit into from Apr 11, 2021

Conversation

pbzweihander
Copy link
Contributor

<3.10 >3 seems not a valid version constraint. And it breaks poetry version resolving. Related issue: python-poetry/poetry#534

This PR fixes the python version constraint for pytest-mypy.

pbzweihander pushed a commit to spoqa/requests-backoff that referenced this pull request Apr 2, 2021
@tony
Copy link

tony commented Apr 11, 2021

This would be a good idea! @jaraco This PR corrects an issue that is breaking versioning on poetry.

As a temporary workaround, @pbzweihander's fix here helped me in pyproject.toml:

"backports.functools_lru_cache" = "!=1.6.2,!=1.6.3" # https://github.com/jaraco/backports.functools_lru_cache/pull/16

@jaraco
Copy link
Owner

jaraco commented Apr 11, 2021

The issue actually lies with Poetry interpreting >3 as >=4 contrary to the spec. See jaraco/backports.entry_points_selectable#2 for another instance. Still, specifying >=3 is a suitable workaround, and since I can release changes faster, I'll relieve the pressure.

@jaraco jaraco merged commit 6a0a4e5 into jaraco:main Apr 11, 2021
jaraco added a commit that referenced this pull request Apr 11, 2021
@jaraco
Copy link
Owner

jaraco commented Apr 11, 2021

Should be fixed in the 1.6.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants