Sync workalendar 7 0 0 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Romania, mixin order matters when mixing in OrthodoxMixin
…ct's refs workalendar#375 and somehow refers to workalendar#288 ; when it has been raised here: workalendar#288 (comment)
Global registry now returns plain built-in dicts instead of OrderedDict's
This Mixin was barely a mixin at all: none of its method was using ``self``. it refers to workalendar#302, but not essentially. The goal of this refactoring is to simplify classes hierarchy, and it might also simplify the swap between `ephem` and `skyfield`.
…tions Removed ``EphemMixin`` in favor of astronomical functions
…ar#394) Fix duration calculation with starting day included or not This patch adds a ``include_start`` argument in the ``get_working_days_delta`` methods to include the starting date in the delta count (or not) closes workalendar#393
Update Turkey Republic Day.
refs workalendar#302, workalendar#348 closes workalendar#398 Many thanks to @GammaSagittarii for the tremendous help on finding the right way to compute Chinese Solar Terms.
…ield Drop (py)ephem dependency in favor of Skyfield
|
I still don't have tox working, but pytest locally and Travis CI seems clean. Please review and consider merging. |
|
Awesome. Thanks so much for this. Not sure what's up with tox, but it runs great for me locally (and in CI). Maybe consider |
|
I'm glad to be able to contribute to one or two of the upstream we depend
on. It is after all the community that makes open source. It's amazing how
few people bother IMHO...
…On Fri, 8 Nov 2019, 19:37 Jason R. Coombs, ***@***.***> wrote:
Awesome. Thanks so much for this. Not sure what's up with tox, but it runs
great for me locally (and in CI). Maybe consider tox -r to rebuild the
environment (or rm -r .tox).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10?email_source=notifications&email_token=ABFHWKM2JKAFHYJYINF7JZLQSW5W3A5CNFSM4JKWYI2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTEPPQ#issuecomment-551962558>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFHWKIRSIEYUPKDBQIAJYLQSW5W3ANCNFSM4JKWYI2A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, here is a NOT-READY-TO-MERGE pull request for a sync with upstream Workalendar v7.0.0.
I have reviewed the deltas, and have not seen anything of note. However, it is not ready to merge because I have been unable to do any testing as tox fails to run in some obscure way on my system:
Possibly some Python2 versus Python3 thing?