-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skyfield VS Ephem #302
Comments
Okay, I just looked deeper at skyfield and it is based on Nasa files. So it needs to be downloaded first. I guess my above comment is not relevant. |
I agree that somehow it's a bit painful to require development packages to use I'll keep your issue in my backlog, for later. thank your for the heads-up! |
@antvig: What's so difficult here? Just run python setup.py build and then python setup.py install --optimize=1 |
On some targets (windows...) recompiling is much less friendly than on others ("let's install windows SDK ! and visual C++ redist ! oh no let's try mingw instead... oh wait the 64 bits version seems to have issues with cpython... oh wait I have to modify a file in the pip distrib to change some includes..." etc.) So I understand that some users may just be afraid of compiling python packages on windows. However @antvig can you explain why you can not use the precompiled "ephem" conda package in your case ? Thanks ! |
it looks like calculating solar terms using Skyfield is a bit harder than I first thought... stay tuned, I didn't say my last word! |
This Mixin was barely a mixin at all: none of its method was using ``self``. it refers to #302, but not essentially. The goal of this refactoring is to simplify classes hierarchy, and it might also simplify the swap between `ephem` and `skyfield`.
look, ma! no pyephem! :o) |
I'm finally able to present a "PyEphem-free" version of workalendar. |
refs #302, #348 Many thanks to @GammaSagittarii for the tremendous help on finding the right way to compute Chinese Solar Terms.
In case any of you is interested in testing the next Workalendar Release Candidate, here's a procedure you may try to follow: #398 |
Cool ! I let @antvig have a look if he can as he has been much more involved than I on this topic |
I will certainly take some time to test it ! |
@antvig any news on this point? |
I'm sorry to have to look a bit pushy, but I'd really want to have at least one more user to confirm that the release candidate is working. So, who can confirm that the RC is working, following the procedure described in #398? |
I just did at the moment ;) |
refs #302, #348 Many thanks to @GammaSagittarii for the tremendous help on finding the right way to compute Chinese Solar Terms.
WOOT! |
refs #302, #348 closes #398 Many thanks to @GammaSagittarii for the tremendous help on finding the right way to compute Chinese Solar Terms.
version 7.0.0 of workalendar has been released and published on PyPI. Upgrade away, to the stars, and beyond! |
Thanks @brunobord ! |
I'm having trouble installing workalendar since it requires ephem which need to be compiled. (I can't use a precompiled conda package for my purpose.)
I've seen that there is the package skyfield which does the same than ephem and that doesn't require to be compiled.
Are you aware of skyfield? If yes, is there a reason why workalendar uses ephem instead of skyfield?
The text was updated successfully, but these errors were encountered: