Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should be able to change keyring 'app name' from 'Python' #36

Closed
jaraco opened this issue Feb 24, 2015 · 5 comments
Closed

should be able to change keyring 'app name' from 'Python' #36

jaraco opened this issue Feb 24, 2015 · 5 comments

Comments

@jaraco
Copy link
Owner

jaraco commented Feb 24, 2015

There should be a mechanism to change the keyring 'application name' from 'Python' to something else. This is especially evident with the kwallet backend.
@jaraco
Copy link
Owner Author

jaraco commented Feb 24, 2015

For those unaware of kwallet behavior, it allows to store passwords in a hierarchical structure. Today, python-keyring stores every passwords it manages into a dedicated "Python" folder, which is solely used by python-keyring.

jnelson > it seems kwallet proposes by default some folders which look reasonable to use, like the "Passwords" folder. Would it make sense to store things inside this one? Or should we rename "Python" into "python-keyring" so that it's clearer?

Actually, kwallet is the only implementation I know which provides a way to store things in a "folder", the service is otherwise used to discriminate entries. It doesn't make much sense, for now, to expose this, IMO. I agree to provide a more meaningful name, though.

Original comment by: Jonathan Ballet

@jaraco
Copy link
Owner Author

jaraco commented Feb 24, 2015

I added pull request #21 which introduced Folder usage for KWallet backend and allows specifying application name.

Original comment by: Maciej Sitarz

@jaraco jaraco closed this as completed Feb 24, 2015
@jaraco
Copy link
Owner Author

jaraco commented Feb 24, 2015

Issue #82 was marked as a duplicate of this issue.

Original comment by: Jason R. Coombs

@jaraco
Copy link
Owner Author

jaraco commented Feb 24, 2015

When playing with bitbucket I deleted the wrong repository, the one from which I requested pull, so pull request #21 disappeared :(

Happily I had the web page opened so I saved all the comments to disk.
I didn't want you too lose all the comments and thoughts so I shared them on dropbox, links below.

I'm really sorry, for the mess.

Comments from pull request #21 (in few formats, choose whatever you like best)

Original comment by: Maciej Sitarz

@jaraco
Copy link
Owner Author

jaraco commented Feb 24, 2015

I'm going to mark this as wontfix, as it's just languishing. Do feel free to put together a pull request or otherwise revive this ticket.

Original comment by: Jason R. Coombs

@jaraco jaraco mentioned this issue Feb 24, 2015
Closed
jaraco pushed a commit that referenced this issue May 20, 2021
@webknjaz
Make sphinx fail on any warnings (#36)
8698127 
This change adds `nitpicky=True` (which is an equivalent of `-n`) to
make Sphinx emit warnings for any references to non-existing targets.
Then, it adds `-W` to make it fail whenever a single warning is seen.
Finally, `--keep-going` allows Sphinx to print out all the warnings
before exiting instead of showing just one and bailing.

Resolves #29

Refs:
* https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-n
* https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-W
* https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-keep-going
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco