-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(use-resize-observer): resolve type conflict #100
Conversation
src/use-resize-observer.ts
Outdated
@@ -1,6 +1,6 @@ | |||
import { ResizeObserver } from "@juggle/resize-observer"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Juggle's ResizeObserver
is a ponyfill so preferably we'd use the one on the window
object when it's available
fix typescript 4.2.3 conflict by replacing resize-observer-polyfill with @juggle/resize-observer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing for SSR then we're good. Thanks! Sorry this took so long.
All good! Thank you for this awesome project! |
I might be mistaken but I think your edit deleted the variable assignment. I've added it back. |
whoops! |
I think your updated |
Do you have any idea how to fix this lint error? Lint is passing locally but not the Github Action. |
I've tried to run lint locally and it fails with the same errors:
PS on main repo it's passing |
Found out that you need to update test, which still references old package and it'll fix linter |
Thank you for looking into it @joxxoxo. I've updated those files. Pending @jaredLunde to trigger the workflow. |
@johnsonsu awesome, looking forward to have TS passing on my project 😀 |
All tests are passing locally for me 🤞 |
## [3.6.3](v3.6.2...v3.6.3) (2022-02-26) ### Bug Fixes * **use-resize-observer:** resolve type conflict ([#100](#100)) ([38b80bc](38b80bc))
🎉 This PR is included in version 3.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for putting this together! I've been super busy lately and I very much appreciate the community effort. |
fix typescript 4.2.3 conflict by replacing
resize-observer-polyfill
with@juggle/resize-observer
Discussion about the type conflict can be found here: https://github.com/que-etc/resize-observer-polyfill/issues/83.\
All existing tests are passing. No new test added.
Closes #101.