exchanges: add scope type validation #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It assures
scope
parameter is a string before we start manipulating it, otherwise you find this type error:scope.split is not a function
There is older PR about this: #170 (but mine solves this for all exchanges + testing)
Notes:
I used
invalid_scope
instead ofinvalid_request
since by spec:I guess wrong format can be in the
malformed
aspect, however, the library already does this check in code grant and it returnsinvalid_request
. I've added another commit in this PR to "fix" that and to unify them toinvalid_scope
, let me know if you prefer the other way around: all of them returninginvalid_request
.The code is repeated in all exchanges, not sure if you have in mind some refactor before or after this PR, let me know if you prefer another validation approach.