Added: support new versions of express #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings when running the test login app Signed-off-by: Alaa Attya Mohamed <vidooman@gmail.com>
Solve the warning deprecated message during authorization.
|
I'll accept this PR if you make it an example in a separate folder. The existing example should be pegged to Express 3.x, in which case it works fine and is useful for people who haven't upgraded to Express 4.x. |
Add docs for authType
Signed-off-by: Alaa Attya <vidooman@gmail.com>
|
Changes Unknown when pulling f37ee21 on AlaaAttya:master into * on jaredhanson:master*. |
Signed-off-by: Alaa Attya <vidooman@gmail.com>
|
Changes Unknown when pulling 73111b2 on AlaaAttya:master into * on jaredhanson:master*. |
|
just did, can you merge it now?! |
|
Example has been updated and moved here: https://github.com/passport/express-4.x-facebook-example Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: support new versions of express to remove the deprecation warnings when running the test login app
Signed-off-by: Alaa Attya Mohamed vidooman@gmail.com