Remove req._passport.session from remaining tests.

jaredhanson · Sep 23, 2021 · e20e3f9 · e20e3f9
1 parent 7f41957
commit e20e3f9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 17 deletions.
diff --git a/test/authenticator.middleware.test.js b/test/authenticator.middleware.test.js
@@ -48,10 +48,6 @@ describe('Authenticator', function() {
         expect(request._passport.instance).to.be.an.instanceOf(Authenticator);
         expect(request._passport.instance).to.equal(passport);
       });
-
-      it('should not expose session storage on internal request property', function() {
-        expect(request._passport.session).to.be.undefined;
-      });
     });
 
     describe('handling a request with custom user property', function() {
@@ -88,10 +84,6 @@ describe('Authenticator', function() {
         expect(request._passport.instance).to.be.an.instanceOf(Authenticator);
         expect(request._passport.instance).to.equal(passport);
       });
-
-      it('should not expose session storage on internal request property', function() {
-        expect(request._passport.session).to.be.undefined;
-      });
     });
 
   });

diff --git a/test/http/request.test.js b/test/http/request.test.js
@@ -43,7 +43,8 @@ describe('http.ServerRequest', function() {
       req.isUnauthenticated = request.isUnauthenticated;
       req._passport = {};
       req._passport.instance = passport;
-      req._passport.session = {};
+      req.session = {};
+      req.session['passport'] = {};
 
       var error;
 
@@ -72,7 +73,7 @@ describe('http.ServerRequest', function() {
       });
 
       it('should not serialize user', function() {
-        expect(req._passport.session.user).to.be.undefined;
+        expect(req.session['passport'].user).to.be.undefined;
       });
     });
 
@@ -86,7 +87,8 @@ describe('http.ServerRequest', function() {
       req.isUnauthenticated = request.isUnauthenticated;
       req._passport = {};
       req._passport.instance = passport;
-      req._passport.session = {};
+      req.session = {};
+      req.session['passport'] = {};
 
       var error;
 
@@ -119,7 +121,7 @@ describe('http.ServerRequest', function() {
       });
 
       it('should not serialize user', function() {
-        expect(req._passport.session.user).to.be.undefined;
+        expect(req.session['passport'].user).to.be.undefined;
       });
     });
 
@@ -132,7 +134,8 @@ describe('http.ServerRequest', function() {
       req.isUnauthenticated = request.isUnauthenticated;
       req._passport = {};
       req._passport.instance = passport;
-      req._passport.session = {};
+      req.session = {};
+      req.session['passport'] = {};
 
       var user = { id: '1', username: 'root' };
       req.login(user, { session: false });
@@ -149,7 +152,7 @@ describe('http.ServerRequest', function() {
       });
 
       it('should not serialize user', function() {
-        expect(req._passport.session.user).to.be.undefined;
+        expect(req.session['passport'].user).to.be.undefined;
       });
     });
 
@@ -293,7 +296,8 @@ describe('http.ServerRequest', function() {
       req.isUnauthenticated = request.isUnauthenticated;
       req._passport = {};
       req._passport.instance = passport;
-      req._passport.session = {};
+      req.session = {};
+      req.session['passport'] = {};
 
       var error;
 
@@ -321,7 +325,7 @@ describe('http.ServerRequest', function() {
       });
 
       it('should not serialize user', function() {
-        expect(req._passport.session.user).to.be.undefined;
+        expect(req.session['passport'].user).to.be.undefined;
       });
     });
 
@@ -347,7 +351,8 @@ describe('http.ServerRequest', function() {
       req.login = request.login;
       req._passport = {};
       req._passport.instance = passport;
-      req._passport.session = {};
+      req.session = {};
+      req.session['passport'] = {};
 
       var user = { id: '1', username: 'root' };