fix issue when the object has a key that is one of the path's parts (#…

…569)
jaredpalmer · Apr 10, 2018 · 095e915 · 095e915
1 parent 636a670
commit 095e915
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/utils.ts b/src/utils.ts
@@ -30,7 +30,7 @@ export function setIn(obj: any, path: string, value: any): any {
 
   for (; i < pathArray.length - 1; i++) {
     const currentPath: string = pathArray[i];
-    let currentObj: any = obj[currentPath];
+    let currentObj: any = getIn(obj, pathArray.slice(0, i + 1));
 
     if (resVal[currentPath]) {
       resVal = resVal[currentPath];

diff --git a/test/utils.test.tsx b/test/utils.test.tsx
@@ -190,6 +190,13 @@ describe('utils', () => {
       expect(obj).toEqual({ x: 'y' });
       expect(newObj).toEqual({ x: 'y', nested: ['value'] });
     });
+
+    it('supports path containing key of the object', () => {
+      const obj = { x: 'y' };
+      const newObj = setIn(obj, 'a.x.c', 'value');
+      expect(obj).toEqual({ x: 'y' });
+      expect(newObj).toEqual({ x: 'y', a: { x: { c: 'value' } } });
+    });
   });
 
   describe('isPromise', () => {