FastField: fallback to default shouldComponentUpdate implementation e…

…ven if custom shouldUpdate implementation returns false (#1238) (#1317)
jaredpalmer · Jun 22, 2019 · 3f8d27d · 3f8d27d
1 parent 49b0706
commit 3f8d27d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/FastField.tsx b/src/FastField.tsx
@@ -109,8 +109,8 @@ class FastFieldInner<Values = {}, Props = {}> extends React.Component<
   shouldComponentUpdate(
     props: FastFieldAttributes<Props> & { formik: FormikContext<Values> }
   ) {
-    if (this.props.shouldUpdate) {
-      return this.props.shouldUpdate(props, this.props);
+    if (this.props.shouldUpdate && this.props.shouldUpdate(props, this.props)) {
+      return true;
     } else if (
       getIn(this.props.formik.values, this.props.name) !==
         getIn(props.formik.values, this.props.name) ||