Call validateFormWithLowPriority with correct values #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using `setValues` `dispatch` is called with type: SET_VALUES and payload: values. However the state update happens asynchronously so when `validateFormWithLowPriority` is called, `state.values` still hasn't been updated. - This fix improves the assertion for the `setValues` validation to test to confirm that the expected value is given to Formik's validate function. - The fix itself is to call `validateFormWithLowPriority` with the `values` parameter given to `setValues` itself, instead of waiting for the `useReducer` to update the state. Currently it does not seem to be possible to wait for `dispatch` to have completed.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/jared/formik-docs/r5wj3ppe6 |
jaredpalmer
approved these changes
Nov 14, 2019
jaredpalmer
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1977
setValuesdispatchis called with type: SET_VALUES andpayload: values. However the state update happens asynchronously so when
validateFormWithLowPriorityis called,state.valuesstill hasn'tbeen updated.
setValuesvalidation to test to confirm that the expected value is given to
Formik's validate function.
validateFormWithLowPrioritywith thevaluesparameter given tosetValuesitself, instead of waiting forthe
useReducerto update the state. Currently it does not seem to bepossible to wait for
dispatchto have completed.