Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated setError signature to string #2215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sjsingh85
Copy link

As per comments on here, updated the signature of setError to take string instead of Value as param.

As per comments on jaredpalmer@e696e57#r36783717, updated the signature of setError to take string instead of Value as param.
@vercel
Copy link

vercel bot commented Jan 15, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/jared/formik-docs/meove6lp8
✅ Preview: https://formik-docs-git-fork-sjsingh85-master.jared.now.sh

@sjsingh85
Copy link
Author

Hi Jared,

This is a small change for typings, Can you confirm what should I do to fix this codesandbox issue?

Thanks

@JamieS1211
Copy link

Had the same issue and was going to do same fix but found this. Looks perfect to me - one line change, short and sweet

@Kaldy14
Copy link

Kaldy14 commented Nov 25, 2020

Any news on this PR? Would be great if it could get fixed

@JamieS1211
Copy link

Labelled stale, perhaps we should re-do this?

@Kaldy14
Copy link

Kaldy14 commented Dec 1, 2020

If you know how that would be awesome :) I dont have any experience opening / fixing PR in open source so I would probably be lost...

@JamieS1211 JamieS1211 mentioned this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants