Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Snack code from external source so it stays up to date #2242

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

brentvatne
Copy link
Contributor

@brentvatne brentvatne commented Jan 24, 2020

You probably want to change it to to a gist on your account @jaredpalmer but yeah this will fix a current issue with the Snack not working and make it less likely to have annoying warnings about SDK versions in the future.

I'm going to follow up on looking into an easier general way for people to include Snack links in their documentation and not have to update them often. We have some stuff for this on https://reactnavigation.org/ but I need to generalize it.


View rendered docs/overview.md
View rendered website/versioned_docs/version-2.0.3/overview.md

@vercel
Copy link

vercel bot commented Jan 24, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@vercel vercel bot requested a deployment to Preview January 24, 2020 16:08 Abandoned
@vercel
Copy link

vercel bot commented Jan 24, 2020

Deployment failed with the following error:

Could not find a secret by name "brent/fix-snack-link"

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 86be101:

Sandbox Source
Formik TypeScript Playground Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants