Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Format PR Review Changes #2280

Merged

Conversation

johnrom
Copy link
Collaborator

@johnrom johnrom commented Feb 8, 2020

Fixes items in review for #2255

I didn't actually get a chance to test it on a real project yet. @jaredpalmer do you use npm link?

I think last time I was having issues with "two reacts" when using npm link. Maybe that's been fixed since then.

@vercel
Copy link

vercel bot commented Feb 8, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/jared/formik-docs/q73cgnjr8
✅ Preview: https://formik-docs-git-fork-johnrom-johnrom-parse-format.jared.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1b3d5af:

Sandbox Source
Formik TypeScript Playground Configuration

@johnrom
Copy link
Collaborator Author

johnrom commented Feb 9, 2020

Added a small change removing parse and format props from the underlying <input /> when not passed a complex component. I honestly don't think we should be passing them to complex components either, but didn't have time to think it through so I left it for now.

I was having the double-react issue again. I switched to Yarn, which seemed to help once every few builds, but then I'd get the same error again. Basically, after running yarn link (/packages/formik), yarn link formik (../formik-dev), yarn build (/) and yarn start (../formik-dev), I had to delete /node_modules because the linked formik would traverse its real path's node_modules and find a second react in the lerna root. Is there a better workflow for this?

image

@johnrom johnrom requested a review from jaredpalmer March 2, 2020 16:04
@jaredpalmer
Copy link
Owner

@johnrom re: lerna, i can commit a tsdx playground that uses parcel to alias the react install

@jaredpalmer jaredpalmer merged commit ca194f7 into jaredpalmer:feat/parse-format Mar 9, 2020
@johnrom johnrom deleted the johnrom/parse-format branch March 9, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants