Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FormikApi + FormikState Subscriptions #3089

Closed
wants to merge 30 commits into from
Closed

Use FormikApi + FormikState Subscriptions #3089

wants to merge 30 commits into from

Commits on Mar 8, 2021

  1. Started to reimplement subscriber. 

    Added Ref State.
Added useSelectorComparer.
Starting to build subscriptions.
    @johnrom
    johnrom committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    9f8765e View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Grab types from other PR, to simplify later.

    @johnrom
    johnrom committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    4dc160b View commit details
    Browse the repository at this point in the history

  2. Grab types from other PR, to simplify later.

    @johnrom
    johnrom committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    ef66e38 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'johnrom/subscriber' of github.com:johnrom/formik into j… 

    …ohnrom/subscriber
    @johnrom
    johnrom committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    b77d371 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Set up dev environment and implement Field. 

    use-subscriptions might not work in React 17? Seems returning the previous value doesn't bail out the render.
    @johnrom
    johnrom committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    3e6e20c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Memoize Formik API and make it rain optimized states. 

    Sync up formik-native and formik for v3.
    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    881d7e6 View commit details
    Browse the repository at this point in the history

  2. Roll back unnecessary tsconfig change.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b8e7fcd View commit details
    Browse the repository at this point in the history

  3. Fix Sign In App Page.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    feaee0e View commit details
    Browse the repository at this point in the history

  4. Roll back unnecessary tsconfig change.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a5a2f47 View commit details
    Browse the repository at this point in the history

  5. Wire up FormikConsumer.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    4037473 View commit details
    Browse the repository at this point in the history

  6. Remove implementation details from deprecated comments.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e2c496c View commit details
    Browse the repository at this point in the history

  7. Don't expose internal useOptimizedSelector.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a78459b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Move useFormikComputedState to api.useComputedState, useIsDirty and u… 

    …seIsValid
    @johnrom
    johnrom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    0d1cbfd View commit details
    Browse the repository at this point in the history

  2. Accidental import change.

    @johnrom
    johnrom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    0c18ebb View commit details
    Browse the repository at this point in the history

  3. Remove TSConfig path aliases during build.

    @johnrom
    johnrom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    3ab46cd View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. If we're calling our own reducer, we don't need to useReducer! setSta… 

    …te will do. If we call our own reducer then use useReducer dispatch, `state.values !== getState().values`.
    @johnrom
    johnrom committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5011168 View commit details
    Browse the repository at this point in the history

  2. Optimize field meta and computed state with shallow equals.

    @johnrom
    johnrom committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    a5f4643 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Move Computed State into normal state helpers so that FormikState = F… 

    …ormikReducerState + FormikComputedState.

Add Fixtures and Tutorial code to /app.
    @jawnrom
    jawnrom committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    c9b9579 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from jawnstreams/johnrom/downstream 

    Consolidate State and Add Tutorial + Fixtures.
    @johnrom
    johnrom committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    611432a View commit details
    Browse the repository at this point in the history

  3. Clarify RenderState vs GetState. Fix Test.

    @johnrom
    johnrom committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    dc2e2fa View commit details
    Browse the repository at this point in the history

  4. Fix tests with updated /app structure.

    @johnrom
    johnrom committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0764e12 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Remove unused helper components from app/

    @johnrom
    johnrom committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    0079948 View commit details
    Browse the repository at this point in the history

  2. Ignore TypeScript Build Errors during app/ build.

    @johnrom
    johnrom committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    9c4cd01 View commit details
    Browse the repository at this point in the history

  3. Add Changeset

    @johnrom
    johnrom committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    ba1fdb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Isolate subscriptions logic from useFormik to enforce correct use of … 

    …API.

Moved FieldHelpers to their own hooks.
Removed batchedUpdates since we use an Effect.
Some minor type fixes, code and documentation cleanup.
    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    dfde363 View commit details
    Browse the repository at this point in the history

  2. Fix useFormikState documentation, fix getState stability.

    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    46a6e17 View commit details
    Browse the repository at this point in the history

  3. Get rid of unnecessary, autocompleted import.

    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ee43bb2 View commit details
    Browse the repository at this point in the history

  4. React.SFC -> FC

    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    7949c3d View commit details
    Browse the repository at this point in the history

  5. Null coalesced errors and touched during resetForm.

    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    94b8f22 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. fixed SetValues type, adding functional variant

    @johnrom
    johnrom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    f3bd303 View commit details
    Browse the repository at this point in the history