Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type): add missing return type for useFormik #3092

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

meeroslav
Copy link

Actual:
useFormik has no defined return type, forcing the developer to guess the correct type in order to use the response object as a parameter

Expected:
useFormik returns type FormikProps<Value>

Note:
To make the return type complete, two properties - isInitialValid and enableReinitialize were added.

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2021

⚠️ No Changeset found

Latest commit: 2265158

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 12, 2021

@meeroslav is attempting to deploy a commit to the Formium Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Apr 12, 2021
@johnrom
Copy link
Collaborator

johnrom commented Apr 12, 2021

This will land in v3 #3089

@github-actions github-actions bot removed the stale label Apr 13, 2021
@github-actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label May 14, 2021
@github-actions github-actions bot closed this Jul 14, 2021
@johnrom johnrom removed the stale label Jul 14, 2021
@johnrom johnrom reopened this Jul 14, 2021
@github-actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants