FEATURE: Add optional Id prop on ErrorMessageProps type #3825
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 27af0d4:
|
| @@ -4,6 +4,7 @@ import { getIn, isFunction } from './utils'; | |||
| import { connect } from './connect'; | |||
|
|
|||
| export interface ErrorMessageProps { | |||
| id?: string; | |||
There was a problem hiding this comment.
Should we just allow all typical div attributes and pull off our specific ones during render?
There was a problem hiding this comment.
export interface ErrorMessageProps extends React.HTMLAttributes<HTMLDivElement> {
component?: string | React.ComponentType;
children?: (errorMessage: string) => React.ReactNode;
name: string;
render?: (errorMessage: string) => React.ReactNode;
}Not sure if there's a native-specific version of this?
idprop added toErrorMessagePropsto make it easily testable in e2e tests.NOTE: This change won't affect any functionalities and since it is an optional param, it can be omitted if not needed.
This is my first contribution to this project, please let me know if I missed something..