fix(docs): #3827 link ref to other doc pages is incorrect #3830
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e84b889:
|
| @@ -93,11 +93,11 @@ to `<button onClick={handleReset}>...</button>` | |||
|
|
|||
| #### `handleSubmit: (e: React.FormEvent<HTMLFormElement>) => void` | |||
|
|
|||
| Submit handler. This should be passed to `<form onSubmit={props.handleSubmit}>...</form>`. To learn more about the submission process, see [Form Submission](../docs/guides/form-submission.md). | |||
There was a problem hiding this comment.
I don't think these changes are correct, they work properly on the current live site, see https://formik.org/docs/api/formik#handlesubmit-e-reactformeventhtmlformelement--void
There was a problem hiding this comment.
Yes, I checked the live site is correct, but when navigating around directly in the md file in the GitHub repo will be incorrect
this change makes both md file and the website work properly
| @@ -67,7 +67,7 @@ export const FriendList = () => ( | |||
|
|
|||
| ### `name: string` | |||
|
|
|||
| The name or path to the relevant key in [`values`](./formik.md#values--field-string-any-). | |||
| The name or path to the relevant key in [`values`](./formik#values--field-string-any-). | |||
There was a problem hiding this comment.
I didn't remove .md extension because, in the website src code, the extension will be remove before transforming to a link
and keep .md extension will help navigate around directly in the md file correctly.
No description provided.