Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to move to create-react-context #423

Closed
wants to merge 2 commits into from

Conversation

jaredpalmer
Copy link
Owner

@jaredpalmer jaredpalmer commented Feb 10, 2018

This PR attempts to removes the direct use of prop-types and instead uses create-react-context.

Writing typed render prop components that take a generic is super awkward now. Ugh.

To make tests pass, we will need to either use enzyme mount / or figure out something else

@Dremora
Copy link
Contributor

Dremora commented Apr 20, 2018

Any progress on this one? Right now our app has quite large form which takes up to 1 second to re-render on each key press, especially on mobile devices. We can't use PureComponent because Formik relies on the old context, and thus the components simply don't re-render. FastField is blocked by #560.

@jaredpalmer
Copy link
Owner Author

Will make a college try soon. My team is also upgrading to 16.3 this week

@jaredpalmer
Copy link
Owner Author

See #594 .

@jaredpalmer
Copy link
Owner Author

Any help finishing the move would be greatly appreciated.

@jaredpalmer jaredpalmer deleted the create-react-context branch December 12, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants