New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Arrays example #550

Merged

jaredpalmer merged 1 commit into jaredpalmer:master from saadq:arrays

Apr 2, 2018

Contributor

saadq commented Apr 1, 2018

Old Version: https://codesandbox.io/s/jjlj9w5v2w
Fixed Version: https://codesandbox.io/s/0yj34y8pvn

The current code in the Arrays.js example currently fails to work. You can reproduce the error by doing one of the following:

Remove a friend and then add a friend
Add a friend and then remove a friend

This PR should fix this (and also get rid of the error about a missing key).


          fix Arrays example

7f152a9

Contributor Author

saadq commented Apr 1, 2018

The issue seems to go away without the need for also adding in a check for:

touched.friends[index] &&

But let me know if you'd like me to include that as well.

jaredpalmer merged commit 164b139 into jaredpalmer:master

berdyshev pushed a commit to berdyshev/formik that referenced this pull request


          fix Arrays example (jaredpalmer#550)

3b56a0e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment