Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of handleChange on FormikHandlers #799

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

s-coimbra21
Copy link
Contributor

@s-coimbra21 s-coimbra21 commented Aug 1, 2018

According to the code:

): void | ((eventOrTextValue: string | React.ChangeEvent<any>) => void) => {

: ((e: React.ChangeEvent<any>) => void);

I believe the type handleChange that is on the FormikHandlers interface is incomplete

According to the code [here] (https://github.com/jaredpalmer/formik/blob/7f44262ee4a16371144fa60a196762d9b268a46f/src/Formik.tsx#L290), the type `handleChange` that is on the `FormikHandlers` interface is incomplete.
@jaredpalmer
Copy link
Owner

Nice!

@jaredpalmer jaredpalmer merged commit 955b6d3 into jaredpalmer:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants