test not running in watch mode by default

[tylerthehaas]

Current Behavior

yarn test isn't running in interactive mode

Expected behavior

to have tests run in interactive/watch mode.

Suggested solution(s)

run jest in watch mode when tsdx test is run.

Your environment

Software	Version(s)
TSDX	0.11.0
TypeScript	3.7.2
Browser	N/A
npm/Yarn	Yarn
Node	12.8.1
Operating System	MacOS Mojave version 10.14.4

[swyxio]

can you suggest a way to pass thru all flags down into jest? this might help support all of jest's other features.

[tylerthehaas]

I wonder if we can use bash's $@ as mentioned in this post:

https://stackoverflow.com/a/3816747/6107169

something like jest -- "$@"

[swyxio]

eh i think we have better ways to do that programmatically. but feel free to open up a pr and do what works!

[tylerthehaas]

what do you suggest?

[swyxio]

not sure but check this out:

tsdx/src/index.ts

Lines 559 to 581 in c5f65bc

	const argv = process.argv.slice(2);
	let jestConfig = {
	...createJestConfig(
	relativePath => path.resolve(__dirname, '..', relativePath),
	paths.appRoot
	),
	...appPackageJson.jest,
	};
	try {
	// Allow overriding with jest.config
	const jestConfigContents = require(paths.jestConfig);
	jestConfig = { ...jestConfig, ...jestConfigContents };
	} catch {}
	argv.push(
	'--config',
	JSON.stringify({
	...jestConfig,
	})
	);
	const [, ...argsToPassToJestCli] = argv;
	jest.run(argsToPassToJestCli);

and see how you'd change

[arthurdenner]

@tylerthehaas, sorry if I misunderstood, but isn't yarn test --watch what you need?

[jaredpalmer]

Yeah all we should do is key off of whether CI=true IMHO

[swyxio]

that works. nice 1-2 liner.

[MartijnHols]

Previously I could use yarn test for a single run and yarn test --watch for watching. Is it no longer possible to make it run just once outside of CI now?

[ambroseus]

@MartijnHols just add CI=true explicitly
"test": "CI=true tsdx test --color"
"test:coverage": "CI=true tsdx test --color --coverage"

[swyxio]

or ctrl + C to kill :)

[swyxio]

@MartijnHols @ambroseus we are reverting the "watch mode by default" behavior we added a month ago - sorry for the flipflop. more info #408