Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a github action workflow to release new versions #612

Merged
merged 11 commits into from Nov 18, 2023

Conversation

QuentinLemCode
Copy link
Contributor

Hello

Following the empty 5.3.0 version on NPM, I suggest to use an automated workflow to avoid this in the future.

This PR add a github action workflow to perform automated releases.

The release workflow can only be launched manually with a choice for the type of release (major, minor, patch).
You can add a release message.

Required : Add the NPM authentication token inside repository secrets with the name NPM_AUTH_TOKEN

@TheAlan404
Copy link

is a .npmignore also needed here?

@QuentinLemCode
Copy link
Contributor Author

is a .npmignore also needed here?

Yes I add it

@alumni
Copy link

alumni commented Nov 17, 2023

@jaredwray could you please review this? thanks!

@QuentinLemCode
Copy link
Contributor Author

QuentinLemCode commented Nov 17, 2023

We also need to add the package-lock because npm install will create the file and make npm version fail because of pending changes.

@jaredwray
Copy link
Owner

@QuentinLemCode - thanks for the update on this and we might want to get something a bit more simple where we arent doing the version bump in the code. Either way, I can do an update on that after the merge.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af72f55) 100.00% compared to head (ef3fa10) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #612   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          295       295           
  Branches        76        76           
=========================================
  Hits           295       295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@QuentinLemCode
Copy link
Contributor Author

@QuentinLemCode - thanks for the update on this and we might want to get something a bit more simple where we arent doing the version bump in the code. Either way, I can do an update on that after the merge.

@jaredwray You are welcome
Yes we can do that and trigger the publish on a new release
Don't hesitate to comment the review, I will be happy to help

@guslen
Copy link

guslen commented Nov 17, 2023

Hi @QuentinLemCode,
I had a similar idea, but I used semantic release. Feel free to copy paste from there #613

@guslen guslen mentioned this pull request Nov 17, 2023
3 tasks
@jaredwray jaredwray merged commit d4f354b into jaredwray:master Nov 18, 2023
3 checks passed
@jaredwray
Copy link
Owner

@QuentinLemCode thanks so much for the work on this.

@guslen - I will be doing some tweaks to this to simplify it down but if you have any suggestions let me know and feel free to create an issue to dialogue about it first.

garrappachc pushed a commit to tf2pickup-org/server that referenced this pull request Dec 22, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[cache-manager](https://togithub.com/node-cache-manager/node-cache-manager)
| [`5.3.1` ->
`5.3.2`](https://renovatebot.com/diffs/npm/cache-manager/5.3.1/5.3.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/cache-manager/5.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/cache-manager/5.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/cache-manager/5.3.1/5.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/cache-manager/5.3.1/5.3.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>node-cache-manager/node-cache-manager (cache-manager)</summary>

###
[`v5.3.2`](https://togithub.com/node-cache-manager/node-cache-manager/releases/tag/v5.3.2)

[Compare
Source](https://togithub.com/node-cache-manager/node-cache-manager/compare/v5.3.1...v5.3.2)

##### What's Changed

- Use a github action workflow to release new versions by
[@&#8203;QuentinLemCode](https://togithub.com/QuentinLemCode) in
[jaredwray/cache-manager#612
- adding in prepare for the build by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[jaredwray/cache-manager#618
- fix: exclude sourcemap when package publish by
[@&#8203;czy88840616](https://togithub.com/czy88840616) in
[jaredwray/cache-manager#622
- updating clean to scripts by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[jaredwray/cache-manager#623
- feat: support sync cache creation by
[@&#8203;denkan](https://togithub.com/denkan) in
[jaredwray/cache-manager#598
- 619: Ensure that background refresh only calls fn once. by
[@&#8203;ricall](https://togithub.com/ricall) in
[jaredwray/cache-manager#620
- updating typescript and removing release workflow by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[jaredwray/cache-manager#624
- updating vitest to 1.1.0 by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[jaredwray/cache-manager#625
- upgrading promise-coalesce to 1.1.2 by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[jaredwray/cache-manager#626
- upgrading lru-cache to 10.1.0 by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[jaredwray/cache-manager#627
- upgrading typescript and eslint to latest by
[@&#8203;jaredwray](https://togithub.com/jaredwray) in
[jaredwray/cache-manager#628

##### New Contributors

- [@&#8203;QuentinLemCode](https://togithub.com/QuentinLemCode) made
their first contribution in
[jaredwray/cache-manager#612
- [@&#8203;czy88840616](https://togithub.com/czy88840616) made their
first contribution in
[jaredwray/cache-manager#622
- [@&#8203;denkan](https://togithub.com/denkan) made their first
contribution in
[jaredwray/cache-manager#598
- [@&#8203;ricall](https://togithub.com/ricall) made their first
contribution in
[jaredwray/cache-manager#620

**Full Changelog**:
jaredwray/cache-manager@v5.3.0...v5.3.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tf2pickup-org/server).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants