Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.0.4 is latest on npm, but it's not in the repo #7

Closed
scottnonnenberg opened this issue Dec 20, 2017 · 0 comments
Closed

v0.0.4 is latest on npm, but it's not in the repo #7

scottnonnenberg opened this issue Dec 20, 2017 · 0 comments

Comments

@scottnonnenberg
Copy link

Please push the changes made for 0.0.4 to GitHub, so we can see what we're installing.

These are the changes I discovered when I installed it and diffed it, FYI for anyone else who is wondering...

diff node_modules/electron-icon-maker/package.json ../release/node_modules/electron-icon-maker/package.json
3c3
<   "version": "0.0.4",
---
>   "version": "0.0.3",
32c32
<     "icon-gen": "1.0.7",
---
>     "icon-gen": "^1.0.7",
scottnonnenberg added a commit to signalapp/Signal-Desktop that referenced this issue Jan 12, 2018
@scottnonnenberg
Downgrade electron-builder due to bug, downgrade icon-maker too
636a735 
The latest electron-builder came with a fix for one of our bugs as well
as a new bug that blocks builds on Windows: electron-userland/electron-builder#2462

There's no good reason to upgrade icon-maker. And a good reason to keep at the version on github: jaretburkett/electron-icon-maker#7
scottnonnenberg added a commit to signalapp/Signal-Desktop that referenced this issue Jan 13, 2018
@scottnonnenberg
Dependency updates, fixes required for successful release (#1966)
177dfb3 
* A number of fixes required for successful build after upgrades

- extract now takes an absolute directory only
- something changed, so we now need to force NODE_ENV=production; we use
  electron-is-dev for this
- electron-builder, electron-publisher-s3, and electron-updater are now
  updated to their latest available versions

* Add direct dependency on extract-zip, since we use it directly

* Load 'config' module after we've modified NODE_ENV

* Downgrade electron-builder due to bug, downgrade icon-maker too

The latest electron-builder came with a fix for one of our bugs as well
as a new bug that blocks builds on Windows: electron-userland/electron-builder#2462

There's no good reason to upgrade icon-maker. And a good reason to keep at the version on github: jaretburkett/electron-icon-maker#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaretburkett @scottnonnenberg