Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The -R option doesn't work with -l option #743

Closed
sylphenix opened this issue Sep 28, 2020 · 4 comments · Fixed by #747
Closed

The -R option doesn't work with -l option #743

sylphenix opened this issue Sep 28, 2020 · 4 comments · Fixed by #747
Labels

Comments

@sylphenix
Copy link

Environment details (Put x in the checkbox along with the information)

[x] Operating System: Debian 10
[x] Desktop Environment: fvwm
[x] Terminal Emulator: xfce4-terminal
[x] Shell: bash
[ ] Custom desktop opener (if applicable):
[ ] Program options used:
[ ] Configuration options set:
[ ] Issue exists on nnn master

Exact steps to reproduce the issue

I found that the -R option only works when scrolling exactly to the last entry. For example, there are 17 files in a folder. run nnn -R -l 5, then I enter that folder, and use the mouse wheel to scroll. It will go to 1/17, 6/17, 11/17, 16/17, then rollover to 4/17,... 14/17, 2/17... and go on until 17/17.

@sylphenix sylphenix added the bug label Sep 28, 2020
@jarun
Copy link
Owner

jarun commented Sep 28, 2020

I can't repro this. Tried with 17 files in a dir nnn -R -l 5

@jarun
Copy link
Owner

jarun commented Sep 28, 2020

My compilation options:

sudo make O_NORL=1 O_NOLOC=1 O_NOMOUSE=1 O_NOBATCH=1 O_NOFIFO=1 O_NOSSN=1 O_QSORT=1 strip install

@0xACE
Copy link
Collaborator

0xACE commented Sep 28, 2020

I can't repro this. Tried with 17 files in a dir nnn -R -l 5

I can reproduce this error on master, but can't find the time to spend on this right now. I'll check it out if I have trouble sleeping or or something.

@jarun
Copy link
Owner

jarun commented Sep 28, 2020

Someone who can repro has to fix this one.

leovilok added a commit that referenced this issue Sep 29, 2020
jarun pushed a commit that referenced this issue Sep 29, 2020
* Fix rollover bug

Fixes #743

* Snap to edges in no rollover multiline scroll mode

* Style fix
@jarun jarun mentioned this issue Sep 29, 2020
30 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants