-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToDo list #719
Comments
Hey. How about adding option to enable icons without recompiling? |
Which distro is not allowing you to compile? |
Out of curious how do you automize this for package managers? I guess on archlinux we could just setup som simple alpm-hook to build it on update, but that's just a guess. I think @maximbaz is a package maintainer and may have some good input. I think the problem @timsofteng is experiencing is that he cba to maintain |
We have all the instructions here. |
ArchLinux distributes binary packages, compiled once by package maintainers, same as you distribute binaries via Github release, so the only option left for users who dislike the default behavior is to compile their own binaries, and @timsofteng's request is to control icons via environment variables in runtime instead of make config. |
I'll leave it as a compile-in feature. Given the few library deps, it's quite easy to compile nnn. Primary reason: icons add significantly to the memory usage and binary size of nnn. And we have several users who don't want these bells and whistles at the cost of increased resource usage. |
I'm using nixos with declarative config and I don't wanna care about any compiling. I have one config which include options for everything in my system. |
There are several other nice FMs which enable icons by default. Pick one of those. |
I don't ask to enable it by default. I ask to have ability to enable it without recompiling. |
I guess the reasoning against baking in the support for icons, is that it increases the size of the binary. Tbh, most of the additional changes would barely have any measurable effect on Fyi maintaining Finally, what you are advocating is that the official release pre-compiles with support for icons. Icons which themselves requires an intrusive setup. I guess "vanilla" icon support would help adoption of I'm not familiar with |
That's correct. I meant having the capability to show icons in the binary. Because of the reasons I mentioned earlier. |
Hi |
When you say copy, I understand it's copy to clipboard. Please try the option if you want to get the path in the terminal, read https://github.com/jarun/nnn/wiki#selection As I understand from your question, you haven't read the documentation. We can't keep re-iterating documented stuff that we have already spent time on. Thank you for your understanding. |
Hey. is there any way to use nnn to select files to upload to browsers Firefox and Chrome? |
How do you upload to browsers from the terminal? I don't understand the use case. You can upload and share files from nnn. There's a plugin to do that. You can also open a file using your browser using "open with..." |
Can |
No, because of several reasons:
|
BTW, another way to navigate fast is to use ' to just to the first file or next matching char. |
one doesn't need to mentally count 15 lines if we have relative line numbers
won't always work as expected, especially in the
sure, but if it helps moving around faster in a folder with lots of directories, it might be worth considering adding this feature I think |
I mentioned we do not show line numbers... not sure what you mean by relative
It conflicts with the current mechanism to switch contexts by numbers (we use 1 to 4/8).
No it doesn't just because you are familiar with it. I don't use that feature in vim, for example... and I do not have any issue navigating in vim. I show and use line numbers directly there ( |
Also, the screenshot from @0xACE is from his personal branch. It's not mainline. |
@objectivephoenix another great option if you want to get as vim-ish behaviour as possible from a terminal file manager is vifm. Check it out. I know for sure it has this feature you are requesting, |
The maintainer could easily provide an "nnn" and "nnn-icons-on" package. It wouldn't probably not be a biggie and I think finding a good name would be the hardest job. |
@maximbaz can you check the possibility of adding a package that supports icons out of the box? |
Sure! As was mentioned in this thread, there are no technical challenges in building various flavors of As I understand, in this particular case there are even two different ways to get icons, using Having said that, if you think providing multiple pre-compiled flavors of Finally, on Arch Linux people can easily make use of AUR, a place to share recipes for custom builds, for example someone has already provided nnn-icons package, a flavor that adds |
We can't add 2 different flavours for every distro. In commit 5675786 I have added support for generating 2 additional static binaries with icons-in-terminal and patched nerd font support. I don't have a AUR login anymore. Can you please request the maintainer of the nnn-icons package to generate a package for nnn-nerd as well? Probably after the next release. |
Cool! The packages on AUR need active maintainers, it doesn't help just generating other packages and leaving them lying on AUR - but don't worry, we don't need to pre-create all possible AUR packages, once there is an Arch user who actually wants to use |
Please notify the nnn-icons maintainer anyway in case he is interested. The nerd support is still unreleased so he may not know. |
The nerd font icons seem to have some misalignments on the master branch. There seems to have been some discussion regarding this on the nerd font PR. Is there some modification to be made to get the icons to align? Also, is there any way to set the colors of the icons according to user preferences? For example, use the same coloring as the text (blue for directories, green for executables etc.) |
Can you please provide some more details on what you mean? I don't think all icons take the same space.
Yes, trivial change in icons.h to change the icon color. |
Currently no color is specified for these 2. Which means the color from |
Right, sorry for being vague. What I meant is that the larger icons push the text aside while being displayed. It should be visible in the screenshot (see .pythonrc.py). Would it be possible to get the text to line up to the same column? Another example in case it's not too visible in the above one:
Thanks! This worked for me.
What I meant is, have the color of the icon always match the text next to it. It was just an arbitrary example and I prefer the granular control of icons.h, which I now know about. As in aside, I think that the wiki should advise adding the directory where the executable is placed with |
I think if you specify 0, that would do.
I think it's pretty standard. Tons of packagers have |
In fact the installation section says: "PREFIX is supported, in case you want to install to a different location." Please spend some time on the docs. |
I can look into the spacing issue with Nerd Fonts. Unfortunately it's more a problem with NF themselves, not NNN. The few I've fixed were mostly fixed by changing to an alternate icon that didn't have the spacing issue. Not a great way to test this stuff without a full list of faked extensions. I can harden what's in there and put up an eyeball PR tomorrow with some manual checking if that's satisfactory? |
Also, and just as a reminder, NF provides patched fonts. What one person might see for their font of choice might be different for another font of choice. They should carry the same irregularities, but there's quite a few patched fonts they support. Something to keep in mind. |
Sure thing! |
Another minor cosmetic gripe, but can you add an option to remove/customize the arrows that appear if there are more files above of below the currently highlighted file? I personally don't like the look and find the file count in the status bar enough to know my relative current position. While I would disable it, at the same time I can also see someone else wanting to customize the arrows with a different glyph/ligature instead. |
Sorry, can't add a program option for something this trivial. Initially I too thought it's not of much use, now I see it's a very quick way to know if there's more below or above.
It's not simple enough due to scrolloff and needs you to do the math we are doing in code, mentally. To be more generic - why would you read numbers while scrolling if a single character tells you what you want to know. Finally you can remove the blocks enclosing the following lines from the code (only 1 instance each) to get rid of it:
|
@snide any update on the fonts? I am planning for a release. It would be good to wrap this up as this will be the first release with Nerd support. |
I can take a look at it later today. But don't get your hopes up, I have a feeling that this is more of an issue with the fonts themselves. |
Very much possible, just take a look. We are overdue for a release. |
The two things @raghavmallampalli described seem to not have much in common. The first shows misaligned icons, but they are otherwise correctly printed. I don't have thins behavior with any icons with my nerdfonts. This may be an error with the specific font, but I think they have an automated system for patching so I'm not sure about this. The second is an issue I also experience, but I only have an extra space on the right side. @raghavmallampalli has an extra space on the left for the The common thread for the second problem seems to be that all those icons come from codepoints in the "CJK Compatibility Ideographs" section. That seems to be a section for some Chinese characters in the unicode standard. I assume that replacing those characters with some others would solve that issue. I have nothing for the misalignment that I can't reproduce. |
Cool! The icons are meant for editing to choice and I have linked the relevant header file from the docs half an hr. back. I think we are good here. |
I get the feeling that how the terminals render the text affect how this problem presents itself E.g. my terminal doesn't really care much for ligatures and what not... |
Rolled from #629.
Cooking
make O_NERD=1
]dups
to delete duplicates interactivelyautojump
now supportsjump
andzoxide
gio trash
to Trash [export NNN_TRASH=2
] (Supportgio trash
? #740)+
) next to filename in detail mode (Change selection mark position with detail mode #741)-U
to show user & group info in status bar-J
to disable auto-proceed on select (Add cmdline and runtime options to not move to next entry after select key #713)-D
to show dirs in context color withNNN_FCOLORS
-C
for context colorspreview-tabbed
on ^C (preview-tabbed and ^C #727)-s
/-S
(Persistent session and behavior of$NNN_PIPE
#777)upx
for additional binary compressionO_NOSSN
to compile out sessionsO_NOUG
to compile out user & group infoUp for grabs
For anything else please discuss in this thread.
Contribution guideline.
The text was updated successfully, but these errors were encountered: