-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move twill related code into separate package #37
Comments
+1 to this. I'm quite stuck right now because this doesn't support Python 3 |
You are right. I think to replace twill with selenium would be a good step to python 3. There is space and time to discuss this. |
Totally +1 to this. Today had same issue, when trying port my flask app with |
This is actually becoming more urgent since it looks like you can't even install twill through pypi now
Which means that you can't install flask-testing. To get around it I had to do:
Edit: I think this may be related to pip 1.5.
|
Just wanted to add my +1 to this and the move to selenium over twill. Cheers |
+1 for this issue. It makes it unusable with tox :( |
Hey guys, I have created a branch which removes twill and makes the code fully Python 3 compatible. You can find it here https://github.com/fgimian/flask-testing/tree/python3 To use my version in your requirements.txt, simply add the following:
I'm happy to send a pull request on this but seeing as how I completely removed twill, I doubt it would be merged 😄 Cheers |
@jarus If I implement a branch which supports Python 3 but disables twill when running under Python 3, would you consider merging it? This shouldn't be hard to do and I can update the docs to mention that twill only is supported under Python 2.x 😄 Please let me know mate Cheers |
Would be nice to get this. |
Would be realy nice. |
No worries guys, I'll get onto this over the next few days. Thanks for your support! 😄 |
Pending jarus/flask-testing#37 getting fixed. Death to twill!
Hey guys, just submitted my pull request 😄 Please don't hesitate to ask any questions or let me know if you see any problems. The Travis builds for Flask 0.8.1 and 0.9 are failing on Python 3.3 as it seems only Flask 0.10.1 supports Python 3.3. I'm not aware of a way to setup .travis.yml to avoid testing a particular env for specific Python versions. If anyone knows how to do this, that would be greatly appreciated. Cheers |
Thanks @cvrebert, I'll try to fix it up now 😄 |
I've just made a second commit to the same branch which repairs the Travis issue and now the entire build is passing. Thanks for your help Chris! 😄 Cheers |
Merged into master. Thanks for your contribution. |
Twill itself has not been updated in 6 years and is not compatible with python 3. This means that flask-testing will never be able to support python 3 as long as it depends on twill.
The text was updated successfully, but these errors were encountered: