Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move twill related code into separate package #37

Closed
johnjiang opened this issue Dec 24, 2013 · 16 comments
Closed

Move twill related code into separate package #37

johnjiang opened this issue Dec 24, 2013 · 16 comments

Comments

@johnjiang
Copy link

Twill itself has not been updated in 6 years and is not compatible with python 3. This means that flask-testing will never be able to support python 3 as long as it depends on twill.

@chacken
Copy link

chacken commented Dec 24, 2013

+1 to this. I'm quite stuck right now because this doesn't support Python 3

@jarus
Copy link
Owner

jarus commented Dec 24, 2013

You are right. I think to replace twill with selenium would be a good step to python 3. There is space and time to discuss this.

@playpauseandstop
Copy link

Totally +1 to this. Today had same issue, when trying port my flask app with Flask-Testing in requirements to Python 3.

@johnjiang
Copy link
Author

This is actually becoming more urgent since it looks like you can't even install twill through pypi now

 $ pip install twill
Downloading/unpacking twill
  Could not find any downloads that satisfy the requirement twill
  Some externally hosted files were ignored (use --allow-external twill to allow).
Cleaning up...
No distributions at all found for twill

Which means that you can't install flask-testing.

To get around it I had to do:

pip install twill --allow-external twill --allow-unverified twill

Edit: I think this may be related to pip 1.5.

BACKWARD INCOMPATIBLE pip no longer will scrape insecure external urls by default nor will it install externally hosted files by default. Users may opt into installing externally hosted or insecure files or urls using --allow-external PROJECT and --allow-unverified PROJECT. (Pull #1055)

@fgimian
Copy link
Contributor

fgimian commented Feb 12, 2014

Just wanted to add my +1 to this and the move to selenium over twill.

Cheers
Fotis

@noirbizarre
Copy link
Contributor

+1 for this issue.

It makes it unusable with tox :(

@fgimian
Copy link
Contributor

fgimian commented Feb 14, 2014

Hey guys, I have created a branch which removes twill and makes the code fully Python 3 compatible. You can find it here https://github.com/fgimian/flask-testing/tree/python3

To use my version in your requirements.txt, simply add the following:

git+https://github.com/fgimian/flask-testing.git@python3

I'm happy to send a pull request on this but seeing as how I completely removed twill, I doubt it would be merged 😄

Cheers
Fotis

@fgimian
Copy link
Contributor

fgimian commented Feb 19, 2014

@jarus If I implement a branch which supports Python 3 but disables twill when running under Python 3, would you consider merging it? This shouldn't be hard to do and I can update the docs to mention that twill only is supported under Python 2.x 😄

Please let me know mate

Cheers
Fotis

@jgumbley
Copy link

Would be nice to get this.

@jarus
Copy link
Owner

jarus commented Feb 19, 2014

Would be realy nice.

@fgimian
Copy link
Contributor

fgimian commented Feb 19, 2014

No worries guys, I'll get onto this over the next few days. Thanks for your support! 😄

cvrebert added a commit to hulu/restfulgit that referenced this issue Feb 19, 2014
@fgimian
Copy link
Contributor

fgimian commented Feb 20, 2014

Hey guys, just submitted my pull request 😄

Please don't hesitate to ask any questions or let me know if you see any problems.

The Travis builds for Flask 0.8.1 and 0.9 are failing on Python 3.3 as it seems only Flask 0.10.1 supports Python 3.3. I'm not aware of a way to setup .travis.yml to avoid testing a particular env for specific Python versions. If anyone knows how to do this, that would be greatly appreciated.

Cheers
Fotis

@cvrebert
Copy link

@fgimian
Copy link
Contributor

fgimian commented Feb 20, 2014

Thanks @cvrebert, I'll try to fix it up now 😄

@fgimian
Copy link
Contributor

fgimian commented Feb 20, 2014

I've just made a second commit to the same branch which repairs the Travis issue and now the entire build is passing. Thanks for your help Chris! 😄

Cheers
Fotis

@jarus
Copy link
Owner

jarus commented Feb 23, 2014

Merged into master. Thanks for your contribution.

@jarus jarus closed this as completed Feb 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants