Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for set - validation is skipped when passing {silent: true} #1071

Merged
merged 2 commits into from
Mar 16, 2012
Merged

Conversation

dira
Copy link
Contributor

@dira dira commented Mar 6, 2012

No description provided.

@jashkenas
Copy link
Owner

That's not quite true -- validation of the silently-changed attribute is only deferred until the next "change" event. Mind fixing the patch?

@lfac-pt
Copy link

lfac-pt commented Mar 16, 2012

But that does not make any sense! If I pass {silent: true} the "change" event should never be triggered. The current approach is highly un-intuitive. And if the behavior is this, that should be stated on the documentation. I just spent 3 hours figuring this out...

@lfac-pt
Copy link

lfac-pt commented Mar 16, 2012

Furthermore, I think the best would be to have the options: deferedValidation and silent.

@braddunbar
Copy link
Collaborator

+1 for this change. There is a lot of confusion regarding model.set(..., {silent: true}).

jashkenas added a commit that referenced this pull request Mar 16, 2012
Documentation for set - validation is skipped when passing {silent: true}
@jashkenas jashkenas merged commit a3282f4 into jashkenas:master Mar 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants