Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various code readability ideas #2059

Closed
wants to merge 24 commits into from
Closed

Various code readability ideas #2059

wants to merge 24 commits into from

Commits on Jan 1, 2013

  1. Rename set -> _set

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    7a716da View commit details
    Browse the repository at this point in the history

  2. Make move arg parsing into set.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    4b55656 View commit details
    Browse the repository at this point in the history

  3. Removing unneeded arg parsing from _set.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    608ab81 View commit details
    Browse the repository at this point in the history

  4. Making unset implicit. Means can't have undefined attributes.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    3e00161 View commit details
    Browse the repository at this point in the history

  5. Remove now-unneeded unset option from calls to _set.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    e6afac1 View commit details
    Browse the repository at this point in the history

  6. Getting rid of unneeed unset var in _set.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    0a7a349 View commit details
    Browse the repository at this point in the history

  7. Rename _set -> _change.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    c526c75 View commit details
    Browse the repository at this point in the history

  8. Moving around the furniture.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    24e6091 View commit details
    Browse the repository at this point in the history

  9. More furniture moving.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    babde67 View commit details
    Browse the repository at this point in the history

  10. Removing changed field from Model prototype.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    14d229a View commit details
    Browse the repository at this point in the history

  11. Finishing comment.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    7fea23b View commit details
    Browse the repository at this point in the history

  12. Starting to combine some of the change tracking fields into an object.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    a745894 View commit details
    Browse the repository at this point in the history

  13. Moving more stuff into ChangeTracker.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    2a9fcc3 View commit details
    Browse the repository at this point in the history

  14. Moving _changeEventsPending into ChangeTracker.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    d575f42 View commit details
    Browse the repository at this point in the history

  15. Clearing up eventsPending logic some.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    1fecb8d View commit details
    Browse the repository at this point in the history

  16. Move triggering change events into ChangeTracker.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    f30624a View commit details
    Browse the repository at this point in the history

  17. Rename method.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    fc28aa9 View commit details
    Browse the repository at this point in the history

  18. Unify triggering of events.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    e13122a View commit details
    Browse the repository at this point in the history

  19. Preparing to switch to call counting.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    a2bb1a3 View commit details
    Browse the repository at this point in the history

  20. Using call counts

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    96a7fd5 View commit details
    Browse the repository at this point in the history

  21. Some tidying.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    5eac4c7 View commit details
    Browse the repository at this point in the history

  22. Move changes into ChangeTracker

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    6f0569d View commit details
    Browse the repository at this point in the history

  23. Moving some methods into ChangeTracker that belong there.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    1dfd2d8 View commit details
    Browse the repository at this point in the history

  24. Comments and other tweaks.

    @gigamonkey
    gigamonkey committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    6571800 View commit details
    Browse the repository at this point in the history