add documentation about collections containing polymorphic models. Fixes... #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice. This has needed some documentation for quite some time. Thanks @hshoff! |
braddunbar
added a commit
that referenced
this pull request
Mar 9, 2013
add documentation about collections containing polymorphic models. Fixes...
|
🍻 |
| return new PublicDocument(attrs, options); | ||
| } else { | ||
| return new PrivateDocument(attrs, options); | ||
| } |
There was a problem hiding this comment.
Might be good to show return this as well. To "pass-through".
There was a problem hiding this comment.
Hmm...I don't follow. Why return this?
There was a problem hiding this comment.
Because it's not obvious how to pass through and use the default model type otherwise.
There was a problem hiding this comment.
Returning this wouldn't do that anyway though, right? It would return an empty object. You could presumably do Backbone.Model.apply(this, arguments) or return new Backbone.Model(attrs, options) though I'm not sure that's any more instructive in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2338 and borrows from an example Jeremy wrote in #793 (comment)