Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for IE7/IE8 build #3690

Merged
merged 1 commit into from
Jun 24, 2015

Conversation

sophietk
Copy link
Contributor

Wrapping test object keys as string to avoid IE7/IE8 error (reserved identifiers).
Tests were added with #3667 : https://travis-ci.org/jashkenas/backbone/builds/66548299.

jridgewell added a commit that referenced this pull request Jun 24, 2015
@jridgewell jridgewell merged commit c3c3d6a into jashkenas:master Jun 24, 2015
@jridgewell
Copy link
Collaborator

Thanks for looking into it!

@akre54
Copy link
Collaborator

akre54 commented Jun 24, 2015

Grr oldIE.

Thanks for the quick fix.

@megawac
Copy link
Collaborator

megawac commented Jun 24, 2015

Hmm, we should set up (actually run) linting for backbone
/cc @michaelficarra

@michaelficarra
Copy link

Yes, probably. A linting step is basically free, and takes 5 minutes to set up. I suggest someone with more familiarity with the project than myself does this, though.

@akre54
Copy link
Collaborator

akre54 commented Jun 24, 2015

It's already set up. We could use eslint, like Underscore, too though.

@megawac
Copy link
Collaborator

megawac commented Jun 24, 2015

It's already set up. We could use eslint, like Underscore, too though.

Yeah but we don't run it through CI and haven't updated it in a long time

@akre54
Copy link
Collaborator

akre54 commented Jun 24, 2015

For sure, but it would be a one line change to set it up with CI. I'd be fine just cribbing Underscore's .eslintrc here.

@michaelficarra
Copy link

If the projects follow similar styles and have similar browser support, I'd say that's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants