Issue #1354, 'in' with splatted arrays.

jashkenas · May 15, 2011 · d91ccd4 · d91ccd4
1 parent 15ddb8e
commit d91ccd4
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/lib/nodes.js b/lib/nodes.js
diff --git a/src/nodes.coffee b/src/nodes.coffee
@@ -1355,7 +1355,9 @@ exports.In = class In extends Base
   invert: NEGATE
 
   compileNode: (o) ->
-    if @array instanceof Value and @array.isArray()
+    isArray = @array instanceof Value and @array.isArray()
+    splat   = obj for obj in @array.base.objects when obj instanceof Splat if isArray
+    if isArray and not splat
       @compileOrTest o
     else
       @compileLoopTest o

diff --git a/test/operators.coffee b/test/operators.coffee
@@ -187,6 +187,10 @@ test "#768: `in` should preserve evaluation order", ->
 test "#1099: empty array after `in` should compile to `false`", ->
   eq 1, [5 in []].length
   eq false, do -> return 0 in []
+
+test "#1354: optimized `in` checks should not happen when splats are present", ->
+  a = [6, 9]
+  eq 9 in [3, a...], true
 
 
 # Chained Comparison