Release 1.3.2

[paulmillr]

Again, many companies stuck with 1.2.0 because of use strict - constructor.name bug. I think this should be released in the nearest time. Not to mention other bugs.

[michaelficarra]

Agreed. I think @jashkenas was cleaning up some bugs yesterday in preparation for a release, but we didn't see one.

edit: Comparison for those who are curious about what has changed.

[jashkenas]

I'm going through a few, but I'm also not terribly urgent about cutting a release before knocking down a few more bugs ... Can you simply not "use strict" for the moment? If your code is correct, it only slows it down.

[michaelficarra]

@jashkenas: 46ff770 fixed another pretty big issue to those trying to use 1.3.1. And c573776, 53a82da, and 3b1a566 all fix things that could also be causing them problems.

[paulmillr]

As far as I know, the slowdown is very low, about <5%.

I love that it throws error for frozen / sealed objects.

(function() {
  'use strict';
  var obj = Object.freeze({a: 1});
  obj.a = 2;
})();

Chaplin freezes objects in many places (mutability sucks) which prevents from doing stupid errors.

[jashkenas]

How can you use Object.freeze? No IE support in MoviePilot?

[paulmillr]

Object.freeze? object, of course.

[jashkenas]

@paulmillr: Can you take a spin on the current master, and confirm for us that it's all currently working correctly for your app?

[paulmillr]

@jashkenas just tried, seems that everything works correctly.

Also I see the bug with no \n after */ was fixed which is awesome

/*console.debug 'Route#addParamName', match, paramName
      */      if (this.paramNames == null) this.paramNames = [];

[geraldalewis]

I'm also not terribly urgent about cutting a release before knocking down a few more bugs

Any bugs in particular? (working on finishing up #2213)

[jashkenas]

One that would be nice is that I've noticed some incorrect formatting here and there, stuff like:

  if (a) {
  b;
}

... and extra spaces at the top level, and the like. But nothing really in particular.

[paulmillr]

two weeks bump.

Have been using master for this period, everything is fine.

[michaelficarra]

@jashkenas: BUMP BUMP BUMP BUMP BUMP. We're already seeing the inevitable duplicates of fixed issues.

[jashkenas]

Bump.

[geraldalewis]

Don't know if you guys saw my final patch for the splatted params "isArray" issue: #2299.

[michaelficarra]

@geraldalewis: I saw, but haven't had a chance to review it. I enabled notifications, expecting to read someone else's review, but it seems nobody wants to look at it. I've moved it up on my priority list. I'll get to it soon if somebody doesn't beat me to it.

update: merged

[geraldalewis]

@michaelficarra Thanks! You might find the discussion in #2213 helpful. @satyr suggested moving the isX helper functions onto Base; I feel they belong on Value. The patch in #2299 punts and simply checks that the node is a Value.

[michaelficarra]

Ping. @jashkenas: we really need to get this release out. The current stable release is embarrassing. Also, we're getting duplicates of these major issues left and right.

[paulmillr]

ping-pong bros

[jashkenas]

(Sorry, was away for the weekend.) No one has anything else lingering they want to get in to a 1.3.2?

[michaelficarra]

I really really really want to review and merge #2017, but not more than I want to get a point release out so people can finally upgrade to 1.3.x.

[jashkenas]

It really doesn't look too ready, or even close, just considering that try/catch for control flow. Let's leave it be for the moment.

[michaelficarra]

Perfect. That means we can get a release out?

[jashkenas]

@michaelficarra Are you all wrapped up on your series of commits surrounding 848d105 ?

[michaelficarra]

For now, yeah. I reverted the start of a fix for #2306, so it's stable and clean.

[jashkenas]

Done.

[michaelficarra]

Awesome!

[paulmillr]

fuk yes, thanks Jeremy!