'coffee' silently fails with no output when the --join option is specified and the source files specified include directories

[johnyanarella]

The command-line compiler fails silently with no output when the --join option is specified and the source files specified include directories.

The current --join handling logic in compile() assumes that the source being compiled is among the explicit list of source files specified for compilation. When one of those source files is a directory, compile() is called recursively with files that were not among the original explicitly specified list of source files, invalidating that assumption.

This patch tweaks the compileScript logic to ensure that the recursively read directory content is aggregated and joined, while still preserving the content order of the original source files specified at the command line.

For instance:

coffee --join output.js --compile src/Main.coffee src/model/ src/service/

would join Main.coffee + all .coffee files (recursively) in src/model + all .coffee files (recursively) in src/service/

[michaelficarra]

Since this approach changes the ::compile API, it's going to have to wait until at least the next major release before being merged.

[johnyanarella]

To clarify - this just alters the named closure within command module's private compileScript method, which has no relation to the public compile method exported by the coffee-script module.

[johnyanarella]

Sorry - I can see how the original description would be misleading. :)

[michaelficarra]

Oh, you're right. My mistake. Looks good to me.