Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

?= compilation #1216

Closed
michaelficarra opened this issue Mar 21, 2011 · 5 comments · Fixed by #1353
Closed

?= compilation #1216

michaelficarra opened this issue Mar 21, 2011 · 5 comments · Fixed by #1353
Labels
change

Comments

@michaelficarra
Copy link
Collaborator

Currently, a=0; a ?= b compiles to

var a;
a = 0;
a != null ? a : a = b;

I propose changing the last line to a != null || (a = b); or if(a == null) a = b; (no preference here) when its value goes unused like this.
@satyr
Copy link
Collaborator

satyr commented Mar 21, 2011

a != null && (a = b);

||?

@michaelficarra
Copy link
Collaborator Author

Yes, ||. Fixed.

@geraldalewis
Copy link
Contributor

Working on this now.

geraldalewis added a commit to geraldalewis/coffee-script that referenced this issue May 10, 2011
@geraldalewis
Fix for jashkenas#1216 ?= compilation
2212e95
michaelficarra added a commit that referenced this issue May 11, 2011
@michaelficarra
reverting tests from @geraldalewis's fix for #1216
a024ec5
geraldalewis added a commit to geraldalewis/coffee-script that referenced this issue May 11, 2011
@geraldalewis
Fix for jashkenas#1216 and pull jashkenas#1348; preserves original se…
51b7142 
…mantics while prettying the compiled output
geraldalewis added a commit to geraldalewis/coffee-script that referenced this issue May 11, 2011
@geraldalewis
Updated tests for jashkenas#1216 and pull jashkenas#1348
bd8d828
@jashkenas
Copy link
Owner

Gerald's new fix for this is merged to master.

@geraldalewis
Copy link
Contributor

Thanks @jashkenas :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1216 1348 geraldalewis/coffee-script
4 participants
@geraldalewis @jashkenas @satyr @michaelficarra