Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on node v4.x #4610

Closed
MylesBorins opened this issue Jul 11, 2017 · 3 comments
Closed

Tests failing on node v4.x #4610

MylesBorins opened this issue Jul 11, 2017 · 3 comments
Labels

Comments

@MylesBorins
Copy link

Seems like you are using a RegExp feature that is not supported in v4.x

The failure is caused by the test found on line 290 of test/regexps.coffee

failed 1 and passed 852 tests in 3.70 seconds

  #4248: Unicode code point escapes
  SyntaxError: Invalid flags supplied to RegExp constructor 'u'
    at new RegExp (native)
    at Function.<anonymous> (/Users/mborins/code/coffeescript/test/regexps.coffee:1:1)
    at global.test (/Users/mborins/code/coffeescript/Cakefile:1:1)
    at Object.<anonymous> (/Users/mborins/code/coffeescript/test/regexps.coffee:1:1)
    at Object.<anonymous> (/Users/mborins/code/coffeescript/test/regexps.coffee:1:1)
    at Module._compile (module.js:1:1)
    at Object.exports.run (/Users/mborins/code/coffeescript/lib/coffee-script/coffee-script.js:1:1)
    at runTests (/Users/mborins/code/coffeescript/Cakefile:1:1)
    at Object.action (/Users/mborins/code/coffeescript/Cakefile:1:1)
    at helpers.extend.invoke (/Users/mborins/code/coffeescript/lib/coffee-script/cake.js:1:1)
    at Object.exports.run (/Users/mborins/code/coffeescript/lib/coffee-script/cake.js:1:1)
    at Object.<anonymous> (/Users/mborins/code/coffeescript/bin/cake:1:1)
    at Module._compile (module.js:1:1)
    at Object.Module._extensions..js (module.js:1:1)
    at Module.load (module.js:1:1)
    at Function.Module._load (module.js:1:1)
    at Function.Module.runMain (module.js:1:1)
    at startup (node.js:1:1)
    at node.js:1:1
@GeoffreyBooth
Copy link
Collaborator

We don’t aim to have the tests succeed in Node 4. See #4502.

If you’d like to submit a PR that disables this test in Node versions below the version that supports unicode regexes, I would merge it, but the tests are assumed to be running in current latest Node.

@MylesBorins
Copy link
Author

I've already disabled in our smoke testing suite... we will keep it disabled.

Node v4 is officially supported until April 2018... so it is possible other people will show up fairly confused. I highly suggest updating the engines field in your package.json

@GeoffreyBooth
Copy link
Collaborator

Our engines field is "node": ">=0.8.0". That refers to the compiler itself, what you get when you run coffee. If that isn’t true, that’s a bug and we will address it.

We’re close to releasing CoffeeScript 2, which will be Node >= 8.

GeoffreyBooth added a commit to GeoffreyBooth/coffeescript that referenced this issue Jul 15, 2017
@GeoffreyBooth GeoffreyBooth mentioned this issue Jul 15, 2017
GeoffreyBooth added a commit to GeoffreyBooth/coffeescript that referenced this issue Jul 15, 2017
GeoffreyBooth added a commit that referenced this issue Jul 17, 2017
* 1.12.7: Update changelog and version number

* Update dependencies

* Improve formatting

* Updated output

* Disable regex Unicode test for runtimes lacking support. Fixes #4610.

* More better

* Bump date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants