Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Heregex escaped space before comment includes comment in transpiled regex #5428

Open
STRd6 opened this issue Oct 13, 2022 · 0 comments · May be fixed by #5435
Open

Bug: Heregex escaped space before comment includes comment in transpiled regex #5428

STRd6 opened this issue Oct 13, 2022 · 0 comments · May be fixed by #5435
Labels
bug help wanted

Comments

@STRd6
Copy link
Contributor

STRd6 commented Oct 13, 2022 •
edited

Input Code

///
a\ # this is a bug
///

Expected Behavior

// this is a bug
/a /;

Current Behavior

// this is a bug
/a #thisisabug/;
  • CoffeeScript version: 2.7.0
STRd6 added a commit to STRd6/coffeescript that referenced this issue Nov 26, 2022
@STRd6
Heregex Comment
a4b6e8a 
Fixes jashkenas#5428

This fix is simple enough but it causes a substantial change in behavior for Heregexes.

`#` inside of a character class shouldn't be considered a comment. By treating `#`
without whitespace in front as non-comments we could have slight compatability with
Python.

There are other places in the CoffeeScript source where people avoided escaping the `#`
by keeping it next to non-whitespace characters even outside of a character class. This
is different than how Python does it and is probably a bug but maybe it is too late with
the de facto CoffeeScript2 behavior.

I'm not sure if this should be merged in since it changes the behavior quite a lot. Maybe
another one for the CoffeeScript3/Civet bucket.

Refs
---
Python Docs: https://docs.python.org/3/library/re.html#re.X
@STRd6 STRd6 linked a pull request Nov 26, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Heregex Comment STRd6/coffeescript
2 participants
@STRd6 @GeoffreyBooth