Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inline comments #9

Closed
weepy opened this issue Dec 27, 2009 · 1 comment
Closed

inline comments #9

weepy opened this issue Dec 27, 2009 · 1 comment
Labels
bug fixed

Comments

@weepy
Copy link

weepy commented Dec 27, 2009

Currently the following produces an error
x: 1 # hello

Presumably that's not a feature ?
@jashkenas
Copy link
Owner

This is now fixed on master, with this commit:
3ad9316

tiye pushed a commit to tiye/coffee-script that referenced this issue Apr 16, 2014
@island205
Merge pull request jashkenas#9 from jiyinyiyong/on-referennce
1f58770 
On referennce
alangpierce added a commit to alangpierce/coffeescript that referenced this issue Oct 31, 2016
@alangpierce
fix: properly set location for string tokens ending in a newline (jas…
c103efc 
…hkenas#9)

Fixes decaffeinate/decaffeinate#457

The existing logic for computing the end location of a string was to take the
end of the string contents, then add the delimiter length to last_column. For
example, `"""abc"""` would have an end position three characters after the `c`.
However, if a string ended in a newline, then the end location for the string
contents would be one line above the end location for the string, so the proper
fix is to move the end location to the next line, not just to shift it to the
right.

This avoids a bug where the location data would sometimes reference a
non-existent location (one past the end of its line), which would confuse
decaffeinate-parser.
@coffeescriptbot coffeescriptbot mentioned this issue Feb 19, 2018
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weepy @jashkenas