Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve literal mode. #2838

Merged
merged 3 commits into from Mar 17, 2013
Merged

Improve literal mode. #2838

merged 3 commits into from Mar 17, 2013

Conversation

marchaefner
Copy link
Collaborator

There are still open problems:

  • Some markdown processors will need an indentation of 8 space in/after a list to indicate code (nested lists require 4 more spaces for each level). So it's either markdown-parsing or some restriction on support.

  • Multiline tokens can consume the non-code part of the document. E.g.

    some text
    
        str = """
    
    this line will get a # and be a string
    
        """
    

* Expect a blank line as delimiter between text and code (jashkenas#2821).
* Don't change indentation of code. It is not necessary and leads to
  erroneous locationData. (jashkenas#2835)
* Don't modify blank lines and reverse the change in the lexer.
* Don't ignore indentation with mixed whitespace.
@marchaefner
Copy link
Collaborator Author

@jashkenas: This is actually meant as a more condensed, (hopefully) readable and location-preserving version of the code in #2821. (I personally find the second version a bit hard to comprehend, for the rather simple thing is does).

@jashkenas
Copy link
Owner

Lovely, thanks a million.

For super deluxe extra bonus points, consider submitting a version of this same patch to Docco as well ... and get your name on the contributors list.

jashkenas added a commit that referenced this pull request Mar 17, 2013
@jashkenas jashkenas merged commit c44826a into jashkenas:master Mar 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants