New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script loading parallelized in browser #3012
Conversation
If this preserves execution order etc etc, I'm all for it :). |
yeah, I know that I should have attach testing code against this feature, but quickly go though the test folder, it seems not easy to write formed unit test code for this async like behavior into existing structure, any suggestion would be great, or should I make one test page on jsFiddle maybe? |
Yes, I'm afraid we don't have tests for this kind of stuff (and I'm not even sure how we should do it) |
Hi, in order to make it easy to test, I've made a Cherry Pick from this PR onto HEAD @566a7da, which after |
Great idea -- but the implementation looks a bit over-complicated to me. Can we simplify a bit before merging? |
@michaelficarra I mean before I start working on this, due to PR #2934 not yet been merged into master, so it couldn't get to run in the browser for testing purpose. And now I've tested with latest master branch, it is working now, |
@jashkenas The code it now has get simplified, and I've performed rebase to current master HEAD @2e40864 for this PR, please let me know if there's still something left, thanks! |
include rebuilt |
Script loading parallelized in browser
turn this:
into this:
btw: they're actual screen capture, not PhotoShopping...