Trivial: Remove trailing whitespace in test/error_messages.coffee #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trailing whitespace is generally considered 'bad style' and is often linted against or even simply removed by text editors. One of the tests in test/error_messages.coffee depended on trailing whitespace, making the file tricky to work with for people whose editor is configured to remove trailing whitespace. The alternative is to use a literal "\n" and escape the line break.
|
Thanks, this has been driving me nuts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trailing whitespace is generally considered 'bad style' and is often linted against or even simply removed by text editors.
One of the tests in test/error_messages.coffee depended on trailing whitespace, making the file tricky to work with for people whose editor is configured to remove trailing whitespace. The alternative is to use a literal "\n" and escape the line break.
I suppose this is personal preference, but given the proliferation of tools to remove trailing whitespace it makes sense to not depend on them when there's an alternative.