Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling for horizontal rules. #62

Merged
merged 2 commits into from Aug 6, 2012
Merged

Conversation

danawoodman
Copy link
Contributor

I've added some CSS to give horizontal rules some styling.

@danawoodman
Copy link
Contributor Author

Curious if this is something that will be merged or not...?

@jashkenas
Copy link
Owner

Haven't gotten a chance to take a look just yet -- sorry.

@danawoodman
Copy link
Contributor Author

No worries. Just checking if the patch needed any tweaking.

@danawoodman
Copy link
Contributor Author

Should I consider this pull request abandoned?

@jashkenas
Copy link
Owner

Nope, just pining for the fjords.

@danawoodman
Copy link
Contributor Author

:)

@keithamus
Copy link
Collaborator

To me the spacing seems a little too large.

For comparison, here are the screenshots:

Original original
New new

@danawoodman
Copy link
Contributor Author

I agree, it's a bit much @keithamus, I've reduced it by half, which should be good.

@keithamus
Copy link
Collaborator

Looking good now. I'm going to merge this in @jashkenas

keithamus added a commit that referenced this pull request Aug 6, 2012
Add styling for horizontal rules.
@keithamus keithamus merged commit 0c4c54e into jashkenas:master Aug 6, 2012
@danawoodman
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants