Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_.each does not pass the container as the 3rd argument to the function #1

Closed
pmuellr opened this issue Oct 29, 2009 · 1 comment
Closed

_.each does not pass the container as the 3rd argument to the function #1

pmuellr opened this issue Oct 29, 2009 · 1 comment
Labels
fixed

Comments

@pmuellr
Copy link

pmuellr commented Oct 29, 2009

In existing Array.prototype.forEach implementations, a 3rd argument is passed to the passed-in function - the original array. _.each should do this also
@jashkenas
Copy link
Owner

Quite right. I've gone through underscore and added the collection as the third argument to all the iterators. It's out along with 0.3.1. Thanks for the suggestion.

jashkenas pushed a commit that referenced this issue Oct 4, 2011
Merge pull request #1 from michaelficarra/isequal
d447165 
Merging @michaelficarra's additions...
@rwaldron rwaldron mentioned this issue Dec 6, 2011
Closed
@machineghost machineghost mentioned this issue Dec 10, 2012
Closed
megawac referenced this issue Feb 8, 2015
@megawac
Node isFinite fix?
e9dba3a
@jashkenas jashkenas mentioned this issue Oct 13, 2016
Merged
jgonggrijp added a commit that referenced this issue Jun 26, 2020
@jgonggrijp
Merge pull request #1 from jashkenas/modularized-words
a9243da 
Small words tweaks to index.js
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jashkenas @pmuellr