Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.7.1 checklist #1855

Closed
1 of 4 tasks
jdalton opened this issue Sep 17, 2014 · 15 comments
Closed
1 of 4 tasks

v1.7.1 checklist #1855

jdalton opened this issue Sep 17, 2014 · 15 comments

Comments

@jdalton
Copy link
Contributor

jdalton commented Sep 17, 2014

Seeing as it's been more than two months [updated] since the release of 1.7.0 and Jeremy mentioned plans for a 1.7.1 it needs to be tackled or dismissed.

@megawac @akre54 If it's to be tackled then it'll need a list of items to track for 1.7.1.

Something like:

  • _.extend (revert own property iteration)
  • _.where (revert own property iteration)
  • _.template param signature change
  • ES5 Array method use

Related to #1841.

@megawac
Copy link
Collaborator

megawac commented Sep 20, 2014

  • Where on empty object seems fine to me IMO and is backwards compatible. I think there was an issue a couple months ago where we discussed it?
  • What keys behaviour are you referring to?

👍 Lets roll this out ASAP

@jdalton
Copy link
Contributor Author

jdalton commented Sep 20, 2014

_.where on empty object seems fine to me IMO and is backwards compatible

Hmm, I made those list items to get the ball rolling w/o doing a thorough review. The idea was for you all to jump in and take over. It looks like the diff between 1.6.0 and 1.7.0 for _.where is the fact that 1.6.0 iterates over inherited source properties where 1.7.0 does not. So something similar to the _.extend change.

What keys behavior are you referring to?

Oops. That's not the first time I've forgotten that 1.6.0, not 1.7.0, introduced the new _.keys behavior :P

I've updated the list.
Feel free to suggest more if 1.7.1 is still happening.

@megawac
Copy link
Collaborator

megawac commented Sep 20, 2014

I'm fine with rolling out 1.7.1 as is. 👎 on reverting the ES5 function use

@jdalton
Copy link
Contributor Author

jdalton commented Sep 20, 2014

👎 on reverting the ES5 function use

The treatment of sparse arrays is a breaking change which is why I listed it. It is tricky to revert.

@megawac
Copy link
Collaborator

megawac commented Sep 20, 2014

Current changes since 1.7.0 -> master

Changes

  • _.extend was reverted to use enumerate in instead of own properties
  • _.property supports null and undefined
  • _.isEqual support for cross frame arrays
  • _.keys shim for IE<9 can enumerate properties defined by Object.prototype

New features

  • _.unzip was added
  • _.isError was added

What should be included in 1.7.1?

/cc @akre54 @jashkenas @michaelficarra

@megawac
Copy link
Collaborator

megawac commented Oct 24, 2014

It's kind of late now, but @jashkenas want to change the default tag on npm back to 1.6.0 until we're ready for 2.0.0?

npm tag underscore@1.6.0 latest

/cc @akre54 @braddunbar

@harrysingh
Copy link

@megawac @jdalton
I missed to follow this thread. So are we planning to roll out 1.7.1?
how do I move ot 1.7 without breaking any of my code?

@harrysingh
Copy link

@megawac @jdalton
Are we planning 1.7.1 roll out? I want to benefit from 1.7 additions without breaking already working code.

@megawac
Copy link
Collaborator

megawac commented Dec 3, 2014

Probably going to be a 1.8 with reverted extend at this point as people have already updated their breaking paths because of 1.7

@harrysingh
Copy link

@megawac Any expected timelines for 1.8?

@jashkenas
Copy link
Owner

Probably in the next week or two.

@megawac
Copy link
Collaborator

megawac commented Dec 5, 2014

Should the _.template change be reverted or left in on the next tag?

@jashkenas
Copy link
Owner

Left alone, I believe.

@OleksandrRakovets
Copy link

Hello guys, had anything happened with releases since August? Bower still downloads 1.7.0 which is 6 month old now.

Do you need any help?

@megawac
Copy link
Collaborator

megawac commented Feb 18, 2015

Hey @OleksandrRakovets checkout #2012. If you take an interest feel free to send prs fixing those issues or documentation against 1.8 branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants