_.escape test suit

[lucky06688]

// handles multiple escape characters at once
var joiner = ' other stuff ';
var allEscaped = escapeCharacters.join(joiner);
allEscaped += allEscaped;
**assert.ok(_.every(escapeCharacters, function(escapeChar) {
  return allEscaped.indexOf(escapeChar) !== -1;
}), 'handles multiple characters');**
assert.ok(allEscaped.indexOf(joiner) >= 0, 'can escape multiple escape characters at the same time');

I can't understand this test in which the 'allEscaped' is not escaped. https://github.com/jashkenas/underscore/blob/v1.9.0/test/utility.js#L142-L14

[jgonggrijp]

@lucky06688 Thanks for reporting. It appears indeed that allEscaped is never used to actually test the behaviour of _.escape and _.unescape. This is still an issue on master:

underscore/test/utility.js

Lines 162 to 169 in 2a93247

	// handles multiple escape characters at once
	var joiner = ' other stuff ';
	var allEscaped = escapeCharacters.join(joiner);
	allEscaped += allEscaped;
	assert.ok(_.every(escapeCharacters, function(escapeChar) {
	return allEscaped.indexOf(escapeChar) !== -1;
	}), 'handles multiple characters');
	assert.ok(allEscaped.indexOf(joiner) >= 0, 'can escape multiple escape characters at the same time');

It appears this has always been the case since these lines were first added in 9c1c3ea. The author probably forgot.