fix erroneous message #1442
Merged
fix erroneous message #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,7 +183,7 @@ | |||
| ok(!_.isEqual(new Boolean(true), new Boolean), 'Boolean objects with different primitive values are not equal'); | |||
|
|
|||
| // Common type coercions. | |||
| ok(!_.isEqual(true, new Boolean(false)), 'Boolean objects are not equal to the boolean primitive `true`'); | |||
There was a problem hiding this comment.
This is incorrect: new Boolean(true) is equal to true.
|
This change should be uncontroversial. :) |
|
Mind rebasing? automerge isnt working here. |
|
I've rebased the commit, @akre54. |
|
Hrrm. Automerge aint working still. Maybe one of the other maintainers can do it (on my phone here). |
|
Another merge conflict was introduced when #1455 was merged. I've rebased again, so this PR should be mergeable again now. |
|
Boom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.