Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix: Use fixed mingw version when building for Windows #44

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jakeru
Copy link
Contributor

@jakeru jakeru commented May 13, 2024

This should fix the CI builds for Windows that has been failing for quite some time with the following error message:

Cannot find path
'... lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\lib\libpthread.dll.a'

By upgrading the egor-tensin/setup-mingw from version v2 to v2.2.0 we are able to specify a specific mingw version.

A too new version of mingw, for example 13.2.0, seems to fail the build for us. So let's use the fixed version 12.2.0 which was working fine before.

This solution is suggested for example here:
egor-tensin/setup-mingw#17 (comment)

This should fix the CI builds for Windows that has been failing for quite some
time with the following error message:

```
Cannot find path
'... lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\lib\libpthread.dll.a'
```

By upgrading the `egor-tensin/setup-mingw` from version `v2` to `v2.2.0` we are
able to specify a specific mingw version.

A too new version of mingw, for example 13.2.0, seems to fail the build for us.
So let's use the fixed version 12.2.0 which was working fine before.

This solution is suggested for example here:
egor-tensin/setup-mingw#17 (comment)
@jakeru jakeru requested a review from jasmcaus as a code owner May 13, 2024 12:38
@jakeru
Copy link
Contributor Author

jakeru commented May 13, 2024

Note that builds for mingw for platform x86 still fails. But now because of a couple of static asserts instead. They are worth looking into at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant