Skip to content

Commit

Permalink
Fix Chrome on CI
Browse files Browse the repository at this point in the history
  • Loading branch information
sgravrock committed Sep 30, 2023
1 parent f0db5ce commit a14dbf0
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions scripts/run-all-browsers
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
run_browser() {
browser=$1
version=$2
os="$3"
description="$browser $version"
if [ $version = "latest" ]; then
version=""
Expand All @@ -12,7 +13,7 @@ run_browser() {
echo
echo "Running $description"
echo
USE_SAUCE=true JASMINE_BROWSER=$browser SAUCE_BROWSER_VERSION=$version npm run ci
USE_SAUCE=true JASMINE_BROWSER=$browser SAUCE_BROWSER_VERSION=$version SAUCE_OS="$os" npm run ci

if [ $? -eq 0 ]; then
echo "PASS: $description" >> "$passfile"
Expand All @@ -23,7 +24,17 @@ run_browser() {

passfile=`mktemp -t jasmine-results.XXXXXX` || exit 1
failfile=`mktemp -t jasmine-results.XXXXXX` || exit 1
run_browser chrome latest

# As of 2023-09-30, Sauce Connect doesn't work with the latest Chrome version
# on the default Linux. Run on Mac OS instead. The OS specification may need to
# be updated or removed when new Chrome versions stop being available on Mac OS
# 12, although historically this has taken several major OS versions.
# See <https://saucelabs.com/products/supported-browsers-devices>.
# On Saucelabs, the test suite frequently runs ~30s slower on Mac OS than it
# does on Linux, so it's probably worth removing the OS specification once Sauce
# Connect works with Chrome latest on Linux again.
run_browser chrome latest "macOS 12"

run_browser firefox latest
run_browser firefox 115
run_browser firefox 102
Expand Down

0 comments on commit a14dbf0

Please sign in to comment.